Conversation
pombredanne
reviewed
Dec 20, 2024
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks! Here are a few comments for your consideration.
IMHO I am not sure we want a PURL for a commit, we should consider using vcs URLs rather than a plain commit id...
I am open to something else that we can design, but if we do that we need a way to get back to the commit.
We are going to have cases that are NOT on GitHub and therefore are just plain git coordinates.
| if commit_id and package_urls: | ||
| for purl in package_urls: | ||
| normalized_purl = normalize_purl(purl) | ||
| package = self.get_or_create_package(normalized_purl) |
Member
There was a problem hiding this comment.
Do we really want to create new packages here? I would have thought we are only adding new CodeFix?
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
collect_fix_commits
branch
from
2b66214 to
7bb44be
Compare
Contributor
Author
|
|
This was referenced Jan 10, 2025
This was
linked to
issues
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References: