Automatic height for table#606
Merged
AyanSinhaMahapatra merged 3 commits intofeature/unittestsfrom Oct 18, 2023
Merged
Conversation
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
AyanSinhaMahapatra
approved these changes
Oct 16, 2023
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
LGTM!
Thanks++ @OmkarPh
Adding some really minor UI suggestions for your consideration, otherwise please merge.
- In the dependencies table in Package Explorer, the row height seems to be a bit too much. This is because of long data file paths, and we should probably have a wider default width for this, to make the row height smaller.
- Consider the case where we detect packages but no dependencies, in this case the
Dependency Scope summary by Package Typetable should not have entries with each package type in the row, but all values as zero. We should show aNo Dependenciesinstead.
…ble dimensions Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Collaborator
Author
Thanks for the suggestions, |
Member
|
Thanks @OmkarPh , merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #598
Applies auto height for
Not affecting Tableview, as its expected to be a full screen view