Working indicator for queries#583
Merged
OmkarPh merged 1 commit intov4.0-react-typescriptfrom Jul 17, 2023
Merged
Conversation
OmkarPh
force-pushed
the
feature/workingIndicator
branch
from
4e6c0a6 to
221c382
Compare
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
OmkarPh
force-pushed
the
feature/workingIndicator
branch
from
221c382 to
52839e6
Compare
AyanSinhaMahapatra
approved these changes
Jul 17, 2023
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Thanks @OmkarPh, the processing icon with the gear looks perfect and shows up in the right place.
Starts showing up from ~5-10 MB scans and works properly for bigger several hundred MB scans too, without freezing.
Collaborator
Author
|
Thanks for the review, merging 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #552