Go to specific file from licenses & packages explorer#572
Merged
OmkarPh merged 9 commits intov4.0-react-typescriptfrom Jun 8, 2023
Merged
Go to specific file from licenses & packages explorer#572OmkarPh merged 9 commits intov4.0-react-typescriptfrom
OmkarPh merged 9 commits intov4.0-react-typescriptfrom
Conversation
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
…pe defs Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
AyanSinhaMahapatra
approved these changes
Jun 2, 2023
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
@OmkarPh Thanks+++ Looks great! Both File->package view and File->License view works perfectly. Putting them here for reference.
…ted in #576 Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
AyanSinhaMahapatra
approved these changes
Jun 8, 2023
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
LGTM! @OmkarPh .
Looks great, go ahead and merge!
I missed in the previous review, the Package -> file, License -> File links works nicely too.
This feature adds a lot of convenience ❤️
Collaborator
Author
|
thanks, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #536
Also fixes #576