License clues section in Licenses explorer#570
License clues section in Licenses explorer#570OmkarPh merged 4 commits intov4.0-react-typescriptfrom
Conversation
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
…pe defs Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
@OmkarPh looks good thanks++
I've tested out with the scan in the issue and this works as expected. Couple of follow ups:
-
Possible UI improvements?
The horizontal and vertical scrollbars are present always here, on the left pane.
In packages view these scrollbars are only present when we have a lot of packages/dependencies or we expand the dependencies and there is scrolling.
IMHO the scrollbars should only be present when scrolling is possible.
This is also present in other views like the packages explorer. -
Grouping same license clues together.
This has to happen from the toolkit side, I'm thinking of adding a new field in the license clues : for_detection as a refinement to be able to group these together. This will be useful where there are a bunch of repeating license clues. We'll then do the needful here to have them similarly as the matches table in license detections then.
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
|
I couldn't reproduce the ugly empty scroll panes on my system (maybe it's OS specific 🤔 ) |
Yeah thought so, these are fixed now! See screenshots below.
|
thanks 😄 |
2 participants
Fixes #565