Fixed window title update & occasional sqlite error for packages#560
Fixed window title update & occasional sqlite error for packages#560AyanSinhaMahapatra merged 1 commit intov4.0-react-typescriptfrom
Conversation
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
OmkarPh
changed the title
There was a problem hiding this comment.
@OmkarPh this looks good, merging this. See also comments for your future consideration.
But we need tests running on CI: both GitHub Actions and Azure in linux/mac/windows (And also make sure local builds are working on these platforms too) for a stable release of workbench btw.
| jsonFilePath.substring(0, jsonFilePath.lastIndexOf(".")) + ".sqlite"; | ||
| } else { | ||
| // FIXME: this is some ugly regex used to get filename with no extension. | ||
| // see: https://stackoverflow.com/questions/4250364/how-to-trim-a-file-extension-from-a-string-in-javascript |
There was a problem hiding this comment.
We need to document the file license when we copy code from elsewhere, and also have a common notice for all files like we have in scancode-toolkit and elsewhere: for example see https://github.com/nexB/scancode-toolkit/blob/develop/src/licensedcode/cache.py#L4
There was a problem hiding this comment.
all stackoverflow code is licensed under CC BY-SA right
so, exactly how should we show this in this file
There was a problem hiding this comment.
This one specifically under https://creativecommons.org/licenses/by-sa/3.0/ yes. We should probably put a line and reference to the text, but I'm not sure of the effect of a sharealike license on the whole file/repo license. @pombredanne @DennisClark what would be recommended here?
There was a problem hiding this comment.
These regex are too small to be relevant copyright-wise IMHO... but this code is also arcane, and this is best rewritten with a cleaner and more readable way.
| } | ||
| mainWindow.webContents.send(IMPORT_REPLY_CHANNEL.JSON, reply); | ||
| }); | ||
| dialog |
There was a problem hiding this comment.
We could have a default here that we can set, like a specific folder that we save the sqlite file in, to save time. This is a refinement of course, no need to do this in this PR.
There was a problem hiding this comment.
yeah makes sense, maybe settings kinda option for users to set the default path
yeah |
Ideally a bit of both? That's not too hard to test right? minimal unit tests and end-to-end tests to ensure most of the functions/parsers and views work? And keep adding specific cases based on bug reports (reproducing by adding a test and then fixing). I'm not familiar at all with ts/react testing so food for thought for you, what would be the way forward here |
|
I think that simply saying that some code is licensed under https://creativecommons.org/licenses/by-sa/4.0/ is sufficient and does not have a significant impact on the overall license of the project, which is all open source with the source code freely available already, and SCWB is basically a standalone application. |
4 participants
Fixes #549