Use default INDEX_URL from Settings to use environment variables#237
Merged
AyanSinhaMahapatra merged 2 commits intoaboutcode-org:mainfrom Jul 22, 2025
Merged
Use default INDEX_URL from Settings to use environment variables#237AyanSinhaMahapatra merged 2 commits intoaboutcode-org:mainfrom
INDEX_URL from Settings to use environment variables#237AyanSinhaMahapatra merged 2 commits intoaboutcode-org:mainfrom
Conversation
This avoids overriding the `INDEX_URL` tuple in `Settings` with the default value from `click` and enables the use of environment variables for `PYINSP_INDEX_URL`. Signed-off-by: Marcel Bochtler <marcel.bochtler@bosch.com>
Signed-off-by: Marcel Bochtler <marcel.bochtler@bosch.com>
Contributor
Author
|
@pombredanne Can you please take a look? |
MarcelBochtler
changed the title
click optionsINDEX_URL from Settings
MarcelBochtler
changed the title
INDEX_URL from SettingsINDEX_URL from Settings to use environment variables
Contributor
|
@pombredanne / @tsteenbe can we please merge this trivial PR ASAP for OCCTET use? |
AyanSinhaMahapatra
approved these changes
Jul 22, 2025
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix @MarcelBochtler, merging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was incorrectly removed in #225