Respect the HTTP_PROXY environment variable#235
Merged
pombredanne merged 2 commits intoaboutcode-org:mainfrom Jul 4, 2025
Merged
Respect the HTTP_PROXY environment variable#235pombredanne merged 2 commits intoaboutcode-org:mainfrom
pombredanne merged 2 commits intoaboutcode-org:mainfrom
Conversation
While `requests` used to respect the HTTP_PROXY and HTTPS_PROXY environment variables, `aiohttp` does not do so by default [1]. Trust the environment variables to enable the use of proxies. [1]: https://docs.aiohttp.org/en/stable/client_advanced.html#proxy-support Signed-off-by: Marcel Bochtler <marcel.bochtler@bosch.com>
MarcelBochtler
force-pushed
the
aiohttp-trustenv
branch
from
1dc2293 to
a5e725f
Compare
Signed-off-by: Marcel Bochtler <marcel.bochtler@bosch.com>
pombredanne
approved these changes
Jul 4, 2025
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks. I guess some tests could have been welcomed, but that would be tantamount to retest aiohttp.ClientSession, ... so we are good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While
requestsused to respect the HTTP_PROXY and HTTPS_PROXY environment, aiohttp does not do so by default 1. Trust the environment variables to enable the use of proxies.