fix: Incorrect parsing of index_urls in requirements.txt#201
fix: Incorrect parsing of index_urls in requirements.txt#201TG1999 merged 3 commits intoaboutcode-org:mainfrom
Conversation
|
@ukaj as tests in CI should be fixed now, can you please rebase your PR? |
|
@ukaj do you mind to add a test too? And is the issue coming from the pip-requirements-parser library? |
@heliocastro, could you take care of this? |
Signed-off-by: ukaj <ukaj869@gmail.com>
ukaj
force-pushed
the
fix/unsupported_url_scheme
branch
from
48882b0 to
a89fcee
Compare
|
Thanks @ukaj for the update. Now @pombredanne or @TG1999, can you please approve the workflow? |
|
Hi, @pombredanne and @TG1999 from Bosch side we would also be very interested in a solution, as we currently have several customers who are affected. It would be amazing if you approve the workflow. Thank you very much! |
|
@kerstin-bosch @sschuberth workflow has been approved but tests are failing. I am looking into how can I fix the failing tests here. |
|
Hi @TG1999, did you have a chance to look at the tests already? Thanks in advance! |
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
|
@kerstin-bosch I have updated the tests, I have also added the missing test for this PR which caused some delay. Merging this soon! Thanks for your patience. |
|
@TG1999: That's really great, thank you very much! :) Are you planning a release soon? |
|
@kerstin-bosch re:
Yes, we have a few pending nasty bugs introduced by asyncio that I work out since last week and ETA for a new release is today. |
5 participants
Before this change, the index_urls variable contained incorrectly parsed values:
After this fix, index_urls is parsed as:
Fixes #173