Replace runtime asserts with explicit errors in non-test code#97
Open
Diwa-Audi wants to merge 5 commits intoaboutcode-org:mainfrom
Open
Replace runtime asserts with explicit errors in non-test code#97Diwa-Audi wants to merge 5 commits intoaboutcode-org:mainfrom
Diwa-Audi wants to merge 5 commits intoaboutcode-org:mainfrom
Conversation
Signed-off-by: diwaaudi <audichyadiwa@gmail.com>
Signed-off-by: diwaaudi <audichyadiwa@gmail.com>
Signed-off-by: diwaaudi <audichyadiwa@gmail.com>
Signed-off-by: diwaaudi <audichyadiwa@gmail.com>
Diwa-Audi
force-pushed
the
replace-asserts-non-test
branch
from
9fef7e0 to
7da112f
Compare
Signed-off-by: diwaaudi <audichyadiwa@gmail.com>
Diwa-Audi
force-pushed
the
replace-asserts-non-test
branch
from
bf3f820 to
e02dcdc
Compare
Author
|
Hi maintainers 👋 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces runtime
assertstatements with explicit exceptionsin non-test code paths.
Why:
assertstatements can be stripped when Python is run with optimizationsScope:
No functional behavior changes are intended beyond clearer error handling.