Skip to content

Replace deprecated update_attributes! with update! - #8

Merged
erikfercak merged 2 commits into
masterfrom
replace_deprecated_update_attributes
May 27, 2021
Merged

Replace deprecated update_attributes! with update!#8
erikfercak merged 2 commits into
masterfrom
replace_deprecated_update_attributes

Conversation

@erikfercak

Copy link
Copy Markdown
Contributor

The update_attributes* methods have been soft deprecated
since 2013 and hard deprecated in Rails 6.1:
NoMethodError: undefined method `update_attributes!'

The update and update! methods should be used instead.

The `update_attributes*` methods have been soft deprecated
since 2013 and hard deprecated in Rails 6.1:
NoMethodError: undefined method `update_attributes!'

The `update` and `update!` methods should be used instead.
@erikfercak
erikfercak requested a review from AlexB52 May 27, 2021 02:19
@erikfercak

Copy link
Copy Markdown
Contributor Author

I did not realize Jordan has did similar PR in #7. Oops.
Mine has the sqlite fix, plus a version bump so I'm gonna keep it here.

@erikfercak
erikfercak requested review from nigelramsay and removed request for AlexB52 May 27, 2021 02:46

@nigelramsay nigelramsay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants