Skip to content

Fix all 7 ESLint errors reported by npm run lint #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joedolson merged 2 commits into from
Aug 25, 2026
Merged

Fix all 7 ESLint errors reported by npm run lint #770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4881464
Fix all 7 ESLint errors on develop
blogcastAI Aug 3, 2026
16ef5be
Remove undocumented data-description-audible fallback
blogcastAI Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions scripts/ableplayer-base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,6 @@ class AblePlayer {
// set to "true" to write description text to a div
if (descriptionsAudible !== undefined && descriptionsAudible === false) {
this.readDescriptionsAloud = false;
} else if (descriptionsAudible !== undefined && descriptionsAudible === false) {
// support both singular and plural spelling of attribute
this.readDescriptionsAloud = false;
} else {
this.readDescriptionsAloud = true;
}
Expand Down
1 change: 1 addition & 0 deletions scripts/dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import $ from 'jquery';
import AblePlayer from './ableplayer-base';

var focusableElementsSelector = "a[href], area[href], input:not([disabled]), select:not([disabled]), textarea:not([disabled]), button:not([disabled]), iframe, object, embed, *[tabindex], *[contenteditable]";

Expand Down
7 changes: 3 additions & 4 deletions scripts/dragdrop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,9 +287,8 @@ function addDragdropFunctions(AblePlayer) {

AblePlayer.prototype.handleWindowButtonClick = function (which, e) {

var thisObj, $windowPopup, $windowButton, $toolbar, popupTop;
var $windowPopup, $windowButton, $toolbar, popupTop;

thisObj = this;
if (this.focusNotClick) {
// transcript or sign window has just opened,
// and focus moved to the window button
Expand All @@ -309,6 +308,7 @@ function addDragdropFunctions(AblePlayer) {
if (e.type === 'keydown') {
// user pressed a key
if (e.key === ' ' || e.key === 'Enter') {
// Space or Enter: fall through to the toggle logic below
} else if (e.key === 'Escape') {
if ($windowPopup.is(':visible')) {
// close the popup menu
Expand Down Expand Up @@ -349,10 +349,9 @@ function addDragdropFunctions(AblePlayer) {

AblePlayer.prototype.handleMenuChoice = function (which, choice, e) {

var thisObj, $window, $windowPopup, $windowButton, resizeDialog, startingWidth, startingHeight,
var $window, $windowPopup, $windowButton, resizeDialog, startingWidth, startingHeight,
aspectRatio, tempWidth, tempHeight;

thisObj = this;
if (which === 'transcript') {
$window = this.$transcriptArea;
$windowPopup = this.$transcriptPopup;
Expand Down
7 changes: 1 addition & 6 deletions scripts/preference.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@
var thisObj, available,
$prefsDiv, formTitle, introText, $prefsIntro,$prefsIntroP2,p3Text,$prefsIntroP3,i, j,
$fieldset, groupHeading, groupObj, thisPref, $thisDiv, thisClass,
thisId, $thisLabel, $thisField, captionsOptions,options,$thisOption,optionValue,optionLang,optionText,
thisId, $thisField, captionsOptions,options,$thisOption,optionValue,optionLang,optionText,
changedPref,changedSpan,changedText, currentDescState, prefDescVoice, prefCaptionVoice, $kbHeading,$kbList,
kbLabels,keys,kbListText,$kbListItem, dialog,$saveButton,$cancelButton,$buttonContainer, sharedDialog;

Expand Down Expand Up @@ -639,7 +639,6 @@
} : undefined
});
$thisDiv = fieldObj.wrapper;
$thisLabel = fieldObj.label;
$thisField = fieldObj.field;
// add a change handler that updates the style of the sample caption text
let viewingOptions = ['prefCaptionsPosition','prefCaptionsFont','prefCaptionsSize','prefCaptionsColor','prefCaptionsBGColor','prefCaptionsOpacity'];
Expand Down Expand Up @@ -752,8 +751,6 @@
checked: this[thisPref] === 1
});
$thisDiv = fieldObj.wrapper;
$thisLabel = fieldObj.label;
$thisField = fieldObj.field;
} else if (this.synth) {
let isDescRateField = (thisPref === 'prefDescRate');
// Only show these options if browser supports speech synthesis
Expand All @@ -771,7 +768,6 @@
} : undefined
});
$thisDiv = fieldObj.wrapper;
$thisLabel = fieldObj.label;
$thisField = fieldObj.field;
if (isDescRateField) {
// Number field has no options to populate.
Expand Down Expand Up @@ -844,7 +840,6 @@
checked: this[thisPref] === 1
});
$thisDiv = fieldObj.wrapper;
$thisLabel = fieldObj.label;
$thisField = fieldObj.field;
if (form === 'keyboard') {
// add a change handler that updates the list of current keyboard shortcuts
Expand Down