Skip to content

Make use of suppress_stdout_stderr when freeing model - #803

Merged
abetlen merged 1 commit into
abetlen:mainfrom
paschembri:fix-verbose-delete
Oct 15, 2023
Merged

abetlen merged 1 commit into
abetlen:mainfrom
paschembri:fix-verbose-delete

Conversation

@paschembri

Copy link
Copy Markdown
Contributor

Fixes #802

@abetlen
abetlen merged commit 10304d7 into abetlen:main Oct 15, 2023
@BlueBlazin

BlueBlazin commented Oct 23, 2023 •

Copy link
Copy Markdown

When I made this change manually on my local llama.py I get the following error:

NameError: name 'open' is not defined

llama_cpp version: 0.2.11
python version: 3.11.0
OS: MacOS Sonoma

Is it just an issue for me or everyone? It's a well known issue that's supposedly fixed in 3.9*:
https://bugs.python.org/issue26789

I can easily resolve this by adding a del model at the end of my code to trigger model deletion before CPython starts shutting down but this is not ideal. Any suggestions?

* Never mind, that fix is for the logging module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logging message "ggml_metal_free: deallocating" is shown when verbose=False

3 participants