Skip to content

Decrement CUDA version and bump Ubuntu - #235

Merged
abetlen merged 2 commits into
abetlen:mainfrom
Pipboyguy:main
May 18, 2023
Merged

abetlen merged 2 commits into
abetlen:mainfrom
Pipboyguy:main

Conversation

@Pipboyguy

Copy link
Copy Markdown

No description provided.

Signed-off-by: Marcel Coetzee <marcel@mooncoon.com>
@abetlen

abetlen commented May 18, 2023 •

Copy link
Copy Markdown
Owner

@Pipboyguy I was just meaning to repond to your issue but it looks like you caught the issue. Yes, it seems CUDA is particular about the minor versions.

Could this be updated to use the docker ARG command for CUDA_VERSION with a default value of 12.1.1, that way you can specify the older version at build time.

Signed-off-by: Marcel Coetzee <marcel@mooncoon.com>
@Pipboyguy

Pipboyguy commented May 18, 2023 •

Copy link
Copy Markdown
Author

Changed as requested @abetlen. Please review

@gjmulder

Copy link
Copy Markdown
Contributor

Passing the CUDA version as an ARG seems like a flexible way to run.

I just have an aversion to version N.0 for any N, as N.1 often fixes a lot of regressions. 🤷‍♂️

@abetlen
abetlen merged commit 69f9d50 into abetlen:main May 18, 2023
xaptronic pushed a commit to xaptronic/llama-cpp-python that referenced this pull request Jun 13, 2023
* fix publish permission

* try to fix docker pipeline using as password github_token & username repository_owner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants