Fix issue #2096: Handle URLs with embedded HTTP credentials in _load_image#2102
Open
nMaroulis wants to merge 1 commit intoabetlen:mainfrom
Open
Fix issue #2096: Handle URLs with embedded HTTP credentials in _load_image#2102nMaroulis wants to merge 1 commit intoabetlen:mainfrom
nMaroulis wants to merge 1 commit intoabetlen:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References:
Fixes Issue #2096
Overview:
Fixes an issue where
_load_imagefails on URLs containing HTTP credentials (e.g., http://user:pass@example.com/image.jpg) and raises http.client.InvalidURL.Solution:
Test plan:
Verified that
_load_imagenow works with: