fix: added missing exit_stack.close() to /v1/chat/completions#1796
Merged
abetlen merged 2 commits intoabetlen:mainfrom Dec 6, 2024
Merged
fix: added missing exit_stack.close() to /v1/chat/completions#1796abetlen merged 2 commits intoabetlen:mainfrom
abetlen merged 2 commits intoabetlen:mainfrom
Conversation
6 tasks
|
+1 to this fix - current we are blocked in bumping our version of llama-cpp-python due to this bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
server.create_chat_completionwould not close the exit_stack if an exception happened while callingllama.create_chat_completion.This PR fixes #1759 and is a superset of #1795.