feat: adding support for external chat format contribution#1716
Open
axel7083 wants to merge 2 commits intoabetlen:mainfrom
Open
feat: adding support for external chat format contribution#1716axel7083 wants to merge 2 commits intoabetlen:mainfrom
axel7083 wants to merge 2 commits intoabetlen:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📖
This PR aims to allow external python package to contribute to the LlamaChatCompletionHandlerRegistry.
Fixes #1715
Security 🔒
This feature is enabled by default, but we could disable it, the idea is to give some control to the users.
Example 🔍
Package outside llama-cpp-python can declare an entrypoint such as bellow
let's say you have a packaged called
timmins-plugin-fancy. You can declare an entrypoint as followedThen when the server would start they would receive a
LlamaChatCompletionHandlerRegistryinstance, which can be used to register custom chat format handler.Inside your timmins-plugin-fancy package you could have the following
Here is what the
__init__.pycould look likes.