adding missing args in create_completion for functionary chat handler#1430
Merged
abetlen merged 1 commit intoabetlen:mainfrom May 8, 2024
Merged
adding missing args in create_completion for functionary chat handler#1430abetlen merged 1 commit intoabetlen:mainfrom
abetlen merged 1 commit intoabetlen:mainfrom
Conversation
Contributor
|
Thanks for this! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like in all cases where
stream == Falsethecreate_completionfunction was missing the new args.I was getting this error when querying functionary v2 on llama-cpp-server: