Conversation
Owner
|
Hey @twaka thank you for the contribution, I'd prefer exposing a MinTokensLogitProcessor instead of adding it as an argument. |
Contributor
Author
|
Thank you for taking a look into! |
Contributor
Author
|
@abetlen Sorry for the delay. I've changed the implementation as you suggested. Could you please take a look? |
Owner
|
Hey @twaka sorry for the delay, and thank you for implementing the change, happy to merge this now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I'm added min_tokens argument which makes eos token's probability to -inf by logits processor when number of generated tokens is smaller than it.
Note that this implementation doesn't prevent stopping generation by another condition (e.g. max_tokens, stop, stopping_criteria).
Completes #240