Fix and optimize functionary chat handler#1282
Merged
abetlen merged 4 commits intoabetlen:mainfrom Mar 18, 2024
Merged
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a breaking bug in the functionary_v1_v2_handler such that it is not able to handle some chat requests as mentioned here. This is a result of wrong logic in the handler.
The following optimizations were done:
tool_choice="auto". In a while loop,\n<|from|>assistantThe second optimization allows for both text response and tool calls to be filled in 1 assistant turn.