Make app server module importable#125
Merged
abetlen merged 3 commits intoabetlen:mainfrom May 1, 2023
Merged
Conversation
Stonelinks
force-pushed
the
app-server-module-importable
branch
from
3afe088 to
ebab54c
Compare
Owner
|
@Stonelinks great work, really appreciate it! I noticed both open PRs have some changes to the pyproject / poetry dependencies, are these necessary? Otherwise I'm good to merge these in once the conflicts are resolved. Cheers |
Define an init_llama function that starts llama with supplied settings instead of just doing it in the global context of app.py This allows the test to be less brittle by not needing to mess with os.environ, then importing the app
Stonelinks
force-pushed
the
app-server-module-importable
branch
from
ebab54c to
efe8e6f
Compare
Contributor
Author
|
@abetlen conflicts resolved and yeah I had to install |
abetlen
approved these changes
May 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all thanks for the awesome library!
I don't want to spam you with a bunch of stuff from my fork but I'll try and keep changes minimal and submit PRs, feel free to keep or ignore whichever ones you see fit.
This one just makes the fastapi server
appimportable as a module (see Stonelinks#1 for more details)