Fix for alias_attribute - #770
Open
i-krav wants to merge 4 commits into
Open
Conversation
|
Code Climate has analyzed commit 19db1b6 and detected 0 issues on this pull request. View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am having an issue on a legacy project with an existing column. Data migration is not an option. It has value with
-in that case AASM won't work, since it is creating a constant with state. An option was to create a custom getter/setter and gsub the-character. But with the current version AASM doesn't work with a custom method, which doesn't have a column in DB. So it is fixing this. So in a couple of words, with this fix it is possible to use a custom method or alias_attribute with AASM without getting an error.