Skip to content

Commit 2590f45

Browse files
committed
External Libraries: Update Masonry shim to prevent error using isAnimated option
Merges [38261] to the 4.6 branch. The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891]. Reported upstream: desandro/masonry-v2-3-shim#1 Props stephenharris, ocean90, azaozz for testing and second sign off. Fixes #37666. See #32802. git-svn-id: https://develop.svn.wordpress.org/branches/4.6@38262 602fd350-edb4-49c9-b593-d223f7449a82
1 parent fbed590 commit 2590f45

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/wp-includes/js/jquery/jquery.masonry.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
var isAniOption = this.options.isAnimated;
2727
if ( isAniOption !== undefined ) {
2828
this.options.transitionDuration = isAniOption ?
29-
Masonry.prototype.options.transitionDuration : 0;
29+
this.options.transitionDuration : 0;
3030
}
3131

3232
if ( isAniOption === undefined || isAniOption ) {

src/wp-includes/script-loader.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ function wp_default_scripts( &$scripts ) {
250250
// It sets jQuery as a dependency, as the theme may have been implicitly loading it this way.
251251
$scripts->add( 'imagesloaded', "/wp-includes/js/imagesloaded.min.js", array(), '3.2.0', 1 );
252252
$scripts->add( 'masonry', "/wp-includes/js/masonry.min.js", array( 'imagesloaded' ), '3.3.2', 1 );
253-
$scripts->add( 'jquery-masonry', "/wp-includes/js/jquery/jquery.masonry$dev_suffix.js", array( 'jquery', 'masonry' ), '3.1.2', 1 );
253+
$scripts->add( 'jquery-masonry', "/wp-includes/js/jquery/jquery.masonry$dev_suffix.js", array( 'jquery', 'masonry' ), '3.1.2a', 1 );
254254

255255
$scripts->add( 'thickbox', "/wp-includes/js/thickbox/thickbox.js", array('jquery'), '3.1-20121105', 1 );
256256
did_action( 'init' ) && $scripts->localize( 'thickbox', 'thickboxL10n', array(

0 commit comments

Comments
 (0)