Merged
Conversation
options.c: refactor around opt->logfile
- Run github actions on Ubuntu 22.04 - Build with gcc-12 and clang-15 - clang-tidy exclude list updated from scratch - Using "-gdwarf-4" because of: llvm/llvm-project#56550 - Added (void) to ignore return values - Added void if no function parameter is used - Default version string updated - valgrind suppression file added - Timeouts raised in case of valgrind test: more important to run stable
aarond10
approved these changes
Oct 24, 2023
aarond10
approved these changes
Oct 24, 2023
aarond10
approved these changes
Oct 24, 2023
Owner
aarond10
left a comment
aarond10
left a comment
There was a problem hiding this comment.
I really don't like the (void) stuff but if the linter likes it, sure. :)
aarond10
approved these changes
Oct 24, 2023
Owner
|
You're a champ! Thank you. |
Contributor
Author
|
You are welcome. About the (void) stuff (Reference: https://clang.llvm.org/extra/clang-tidy/checks/cert/err33-c.html):
|
Owner
|
Yeah. Fair enough. I would prefer an opt-in (like ABSL_MUST_USE_RESULT) but
nevermind!
…On Thu, 26 Oct 2023 at 06:40, baranyaib90 ***@***.***> wrote:
You are welcome.
About the (void) stuff (Reference:
https://clang.llvm.org/extra/clang-tidy/checks/cert/err33-c.html):
1. Ignoring it totally is a no go.
2. Having (void) right there shows - in a nasty syntax way - that
return value is ignored on purpose. (As I recall, clang-tidy recommended
the cast to void.)
3. Plan B would be to have //NOLINT(cert-err33-c) at the end of the
line :S
—
Reply to this email directly, view it on GitHub
<#163 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABTOXTCLX2IZ57NQJ7PIW3YBFTJJAVCNFSM6AAAAAA6OJNYNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZZHEZTMNBRGY>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, briefly: some code modernization and a plan B for #161
Br, Balázs