Merged
Conversation
If can not determine version, this is still better than UNKNOWN
Avoid memory and file descriptor leak.
aarond10
approved these changes
Jan 6, 2023
aarond10
approved these changes
Jan 6, 2023
aarond10
reviewed
Jan 6, 2023
| ... --show-leak-kinds=all --track-origins=yes --keep-stacktraces=alloc-and-free | ||
| ... ${BINARY_PATH} -v -v -v -4 -p ${PORT} | ||
| @{proces_args} = Combine Lists ${default_args} ${args} | ||
| ${proxy} = Start Process valgrind @{proces_args} |
aarond10
approved these changes
Jan 6, 2023
Owner
|
Hey Balázs, Thanks for your many contributions. Sorry to hear you won't be able to contribute much in the future but the project has reached a real level of maturity thanks in a large part to your efforts. Happy New Year and best of luck with whatever you get up to next. :)
|
Contributor
Author
|
Hi Aaron, thank you very much for the kind words! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
only 2 things for now:
I don't have so much time lately, so sadly I will not follow the project from now on.
It was great developing and fixing this proxy. Sometimes it was a bit addictive, but I liked it :)
I hope it has a bright future and will be used by many people.
Best regards,
Balázs