Properly initialize new ca_info option#148
Closed
tofurky wants to merge 1 commit intoaarond10:masterfrom
Closed
Conversation
Otherwise, this can wind up being a garbage non-NULL value that breaks cURL's ability to perform certificate verification: curl error message: error setting certificate verify locations: CAfile: �� CApath: none Fixes aarond10#144. Signed-off-by: Matt Merhar <mattmerhar@protonmail.com>
Contributor
|
Whoopsie, this slipped through the first review :( |
baranyaib90
approved these changes
Oct 9, 2022
Contributor
|
@aarond10 please approve this if you have the time |
Contributor
|
Meh, I just found out the race condition in #136 ... |
Owner
|
Ah, thanks for this. I made the same change yesterday without noticing your pull request. Sorry! I've been away on holidays for the past month. Should have started reading my email from oldest first instead of newest! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, this can wind up being a garbage non-NULL value that breaks cURL's ability to perform certificate verification:
curl error message: error setting certificate verify locations: CAfile: �� CApath: none
Fixes #144.
Signed-off-by: Matt Merhar mattmerhar@protonmail.com