fix: Ensure metadata propagation for Task ToProto and FromProto conversion#557
fix: Ensure metadata propagation for Task ToProto and FromProto conversion#557sokoliva merged 3 commits intoa2aproject:mainfrom
Task ToProto and FromProto conversion#557Conversation
Summary of ChangesHello @sokoliva, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor but important bug where task metadata was not being correctly transferred during type conversion. By adding a single line of code, it ensures that the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly adds metadata propagation from types.Task to a2a_pb2.Task. While the change itself is correct, it is incomplete. The reverse conversion in FromProto.task is missing the metadata field, which will lead to data loss during a round-trip conversion. Additionally, this new functionality is not covered by unit tests. I've added a comment regarding the missing test coverage. To make this fix complete, please also update FromProto.task to handle metadata and add a round-trip test case to verify the behavior.
holtskinner
changed the title
types.Task to a2a_pb2.Task in proto_utils.py
…_conversion_roundtrip`.
sokoliva
changed the title
types.Task to a2a_pb2.Task in proto_utils.pyTask ToProto and FromProto conversion
… to improve readability.
🤖 I have created a release *beep* *boop* --- ## [0.3.16](v0.3.15...v0.3.16) (2025-11-21) ### Bug Fixes * Ensure metadata propagation for `Task` `ToProto` and `FromProto` conversion ([#557](#557)) ([fc31d03](fc31d03)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
3 participants
The
metadatadictionary is now correctly propagated in both theToProto(types.Task to a2a_pb2.Task) andFromProto(a2a_pb2.Task to types.Task) conversion utilities.Fixes #541 🦕