Skip to content

fix: return entire history when history_length=0#537

Merged
lkawka merged 3 commits intoa2aproject:mainfrom
lkawka:history-length-fix
Nov 13, 2025
Merged

fix: return entire history when history_length=0#537
lkawka merged 3 commits intoa2aproject:mainfrom
lkawka:history-length-fix

Conversation

@lkawka
Copy link
Member

@lkawka lkawka commented Nov 7, 2025

Description

The specification states that a history length of 0 should return unlimited results (see code). However, this was recently changed to return 0 results. This fix restores the correct behavior.

Please note that there is an outstanding proposal to change this behavior. See a2aproject/A2A#1071 for more details.

Prerequisites:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests and linter pass (Run bash scripts/format.sh from the repository root to format)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@lkawka lkawka requested a review from a team as a code owner November 7, 2025 23:28
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 7, 2025

Summary of Changes

Hello @lkawka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug where the history_length parameter, when set to 0, incorrectly truncated the task history to an empty list instead of returning the complete history as specified. The changes ensure that a history_length of 0 now correctly retrieves all available history, aligning the implementation with the intended behavior.

Highlights

  • Bug Fix: History Length Interpretation: Corrected a bug where specifying history_length=0 incorrectly resulted in an empty history being returned, instead of the full history as per specification.
  • Logic Adjustment in apply_history_length: Modified the apply_history_length utility function to explicitly check for history_length > 0 before applying history truncation, ensuring that a history_length of 0 bypasses the limiting logic and returns the complete history.
  • Unit Test Updates: Updated relevant unit tests in test_default_request_handler.py to reflect the corrected behavior, changing test cases that previously used history_length=0 to history_length=1 to accurately verify positive history length limiting.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 7, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly restores the specified behavior for history_length=0, ensuring that the entire task history is returned instead of an empty list. The change in src/a2a/utils/task.py is logical and directly addresses the bug. My main feedback is related to testing: the existing tests for history_length=0 were modified to test history_length=1. While this is a valid test case, it's crucial to add new, dedicated tests to verify the history_length=0 behavior to prevent future regressions of the issue this PR is fixing.

@lkawka lkawka requested a review from sokoliva November 12, 2025 21:30
@lkawka lkawka self-assigned this Nov 12, 2025
sokoliva
sokoliva approved these changes Nov 13, 2025
View reviewed changes
Copy link
Contributor

@sokoliva sokoliva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lkawka lkawka merged commit acdc0de into a2aproject:main Nov 13, 2025
6 checks passed
@a2a-bot a2a-bot mentioned this pull request Nov 13, 2025
Merged
lkawka pushed a commit that referenced this pull request Nov 17, 2025
@a2a-bot
chore(main): release 0.3.13 (#543)
ef020c5 
🤖 I have created a release *beep* *boop*
---


##
[0.3.13](v0.3.12...v0.3.13)
(2025-11-13)


### Bug Fixes

* return entire history when history_length=0
([#537](#537))
([acdc0de](acdc0de))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@a2a-bot a2a-bot mentioned this pull request Nov 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sokoliva sokoliva sokoliva approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@lkawka lkawka

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lkawka @sokoliva