Skip to content

fix: Improve error handling in task creation #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
holtskinner merged 5 commits into from
Jul 14, 2025
Merged

fix: Improve error handling in task creation #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ed41537
Improve error handling in task creation
pankaj-bind Jul 10, 2025
d4c93af
fix gemini-code-assist issues
pankaj-bind Jul 10, 2025
e91af9c
Merge branch 'main' into improve-error-handling
holtskinner Jul 14, 2025
cb0e116
Merge branch 'main' into improve-error-handling
holtskinner Jul 14, 2025
a1352ae
formatting
holtskinner Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/a2a/utils/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,16 @@ def new_task(request: Message) -> Task:

Returns:
A new `Task` object initialized with 'submitted' status and the input message in history.

Raises:
TypeError: If the message role is None.
ValueError: If the message parts are empty.
"""
if not request.role:
raise TypeError('Message role cannot be None')
if not request.parts:
raise ValueError('Message parts cannot be empty')

return Task(
status=TaskStatus(state=TaskState.submitted),
id=(request.taskId if request.taskId else str(uuid.uuid4())),
Expand Down
19 changes: 19 additions & 0 deletions tests/utils/test_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,25 @@ def test_completed_task_uses_provided_history(self):
)
self.assertEqual(task.history, history)

def test_new_task_invalid_message_empty_parts(self):
with self.assertRaises(ValueError):
new_task(
Message(
role=Role.user,
parts=[],
messageId=str(uuid.uuid4()),
)
)

def test_new_task_invalid_message_none_role(self):
with self.assertRaises(TypeError):
msg = Message.model_construct(
role=None,
parts=[Part(root=TextPart(text='test message'))],
messageId=str(uuid.uuid4()),
)
new_task(msg)


if __name__ == '__main__':
unittest.main()
Loading