fix: Improve error handling in task creation#294
fix: Improve error handling in task creation#294holtskinner merged 5 commits intoa2aproject:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @pankaj-bind, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly improves the robustness of the task creation process by introducing input validation to the new_task function. It ensures that tasks are only created from valid message objects, preventing potential runtime errors caused by malformed inputs and enhancing the overall stability of the system. Corresponding unit tests have been added to verify this new defensive programming approach.
Highlights
- Enhanced Error Handling: The
new_taskfunction insrc/a2a/utils/task.pynow includes explicit validation for incomingMessageobjects. It checks if therequest.roleisNone(raising aTypeError) and ifrequest.partsis empty (raising aValueError), ensuring that only well-formed messages are used to create tasks. - New Unit Tests: New unit tests have been added to
tests/utils/test_task.pyto cover the new error handling logic. Specifically,test_new_task_invalid_message_empty_partsverifies theValueErrorfor empty message parts, andtest_new_task_invalid_message_none_roleconfirms thatValidationErroris raised by Pydantic when attempting to create aMessagewith aNonerole.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
pankaj-bind
changed the title
There was a problem hiding this comment.
Code Review
This pull request enhances the new_task function by adding input validation for the Message object, specifically checking for a message role and non-empty parts, and includes corresponding unit tests. My review focuses on the correctness of the new tests and the design of the validation logic. I've identified an incorrect test case and suggested a fix, and also provided feedback on centralizing validation logic for better maintainability.
holtskinner
changed the title
🤖 I have created a release *beep* *boop* --- ## [0.2.12](v0.2.11...v0.2.12) (2025-07-14) ### Features * add `metadata` property to `RequestContext` ([#302](#302)) ([e781ced](e781ced)) * add A2ABaseModel ([#292](#292)) ([24f2eb0](24f2eb0)) * add support for notification tokens in PushNotificationSender ([#266](#266)) ([75aa4ed](75aa4ed)) * Update A2A types from specification 🤖 ([#289](#289)) ([ecb321a](ecb321a)) ### Bug Fixes * add proper a2a request body documentation to Swagger UI ([#276](#276)) ([4343be9](4343be9)), closes [#274](#274) * Handle asyncio.cancellederror and raise to propagate back ([#293](#293)) ([9d6cb68](9d6cb68)) * Improve error handling in task creation ([#294](#294)) ([6412c75](6412c75)) * Resolve dependency issue with sql stores ([#303](#303)) ([2126828](2126828)) * Send push notifications for message/send ([#298](#298)) ([0274112](0274112)) * **server:** Improve event consumer error handling ([#282](#282)) ([a5786a1](a5786a1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
2 participants
Description
This update improves the robustness of the
new_taskfunction by adding explicit error handling for invalidMessageobjects.Previously,
new_taskdid not validate its input, which could lead to unexpectedTypeErrororValueErrorexceptions when a malformedMessagewas passed. This change introduces checks to ensure that aMessagehas a validroleand a non-emptypartslist before aTaskis created.Additionally, this update includes corresponding unit tests to verify the new error handling and ensures that the correct exceptions are raised for invalid inputs.
Changes:
src/a2a/utils/task.pytests/utils/test_task.py