Conversation
Signed-off-by: Shingo OKAWA <shingo.okawa.g.h.c@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ognis1205, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new, centralized Pydantic base model, A2ABaseModel, to standardize the configuration of all data models within the a2a library. By having all models inherit from this new base, it ensures consistent behavior, particularly regarding how data is populated, and streamlines future code generation processes.
Highlights
- New Base Model Introduction: Introduced a new custom Pydantic base model,
A2ABaseModel, insrc/a2a/_base.py. This model inherits frompydantic.BaseModeland setsmodel_config = ConfigDict(populate_by_name=True). - Pydantic Model Inheritance Update: All existing Pydantic models within
src/a2a/types.py(e.g.,APIKeySecurityScheme,AgentExtension,JSONRPCError,Task, etc.) have been updated to inherit from the newly createdA2ABaseModelinstead of directly frompydantic.BaseModel. - Automated Code Generation Integration: The
scripts/generate_types.shscript has been modified to include the--base-class a2a._base.A2ABaseModelargument for thedatamodel-codegencommand. This ensures that all future generated Pydantic models will automatically inherit fromA2ABaseModel, maintaining consistency. - Pydantic V2 Compatibility/Feature: The
populate_by_name=Trueconfiguration inA2ABaseModelis crucial for Pydantic v2, allowing model fields to be populated using their original Python attribute names, even when field aliases are defined (e.g., from JSON keys that differ from Python attribute names).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a new A2ABaseModel for all Pydantic types, which is a great way to apply common configuration across the generated models. The implementation correctly enables populate_by_name=True, improving the usability of models with field aliases. I have one suggestion to further enhance the robustness of these models by making them stricter about unexpected fields in payloads.
Signed-off-by: Shingo OKAWA <shingo.okawa.g.h.c@gmail.com>
…_name and validate_by_alias Signed-off-by: Shingo OKAWA <shingo.okawa.g.h.c@gmail.com>
🤖 I have created a release *beep* *boop* --- ## [0.2.12](v0.2.11...v0.2.12) (2025-07-14) ### Features * add `metadata` property to `RequestContext` ([#302](#302)) ([e781ced](e781ced)) * add A2ABaseModel ([#292](#292)) ([24f2eb0](24f2eb0)) * add support for notification tokens in PushNotificationSender ([#266](#266)) ([75aa4ed](75aa4ed)) * Update A2A types from specification 🤖 ([#289](#289)) ([ecb321a](ecb321a)) ### Bug Fixes * add proper a2a request body documentation to Swagger UI ([#276](#276)) ([4343be9](4343be9)), closes [#274](#274) * Handle asyncio.cancellederror and raise to propagate back ([#293](#293)) ([9d6cb68](9d6cb68)) * Improve error handling in task creation ([#294](#294)) ([6412c75](6412c75)) * Resolve dependency issue with sql stores ([#303](#303)) ([2126828](2126828)) * Send push notifications for message/send ([#298](#298)) ([0274112](0274112)) * **server:** Improve event consumer error handling ([#282](#282)) ([a5786a1](a5786a1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
2 participants
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.nox -s formatfrom the repository root to format)Fixes #291 🦕