Skip to content

fix: Event consumer should stop on input_required #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kthota-g merged 2 commits into from
Jun 6, 2025
Merged

fix: Event consumer should stop on input_required #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70ff81a
fix: Event consumer should stop on input_required
kthota-g Jun 6, 2025
f98a5bb
add tests for task.state=input_required
kthota-g Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/a2a/server/events/event_consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ async def consume_all(self) -> AsyncGenerator[Event]:
TaskState.failed,
TaskState.rejected,
TaskState.unknown,
TaskState.input_required
)
)
)
Expand Down
19 changes: 19 additions & 0 deletions tests/server/events/test_event_consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,3 +222,22 @@ async def mock_dequeue() -> Any:
assert len(consumed_events) == 1
assert consumed_events[0] == events[0]
assert mock_event_queue.task_done.call_count == 1

@pytest.mark.asyncio
async def test_consume_task_input_required(
event_consumer: MagicMock,
mock_event_queue: MagicMock,
):
task = Task(**MINIMAL_TASK)
task.status = TaskStatus(state=TaskState.input_required)

async def mock_dequeue() -> Any:
return task

mock_event_queue.dequeue_event = mock_dequeue
consumed_events: list[Any] = []
#consumer should terminate on input_required task
async for event in event_consumer.consume_all():
consumed_events.append(event)
assert len(consumed_events) == 1
assert consumed_events[0] == task