Skip to content

fix: Noargs constructor for Jakarta CDI compatibility #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kabir merged 1 commit into from
Feb 9, 2026
Merged

fix: Noargs constructor for Jakarta CDI compatibility #637

kabir merged 1 commit into from
Feb 9, 2026
+13 −4

Conversation

@kabir
Copy link
Collaborator

@kabir kabir commented Feb 9, 2026

No description provided.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 9, 2026

Summary of Changes

Hello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a compatibility requirement for Jakarta CDI by modifying the MainEventBusProcessor class. It introduces a protected no-argument constructor and adjusts the modifiers of several injected fields. These changes enable CDI to properly proxy and manage instances of MainEventBusProcessor when it is declared as an @ApplicationScoped bean, ensuring that dependency injection functions as expected within the CDI environment.

Highlights

  • CDI Compatibility: A no-argument constructor has been added to the MainEventBusProcessor class to ensure compatibility with Jakarta CDI, specifically for @ApplicationScoped beans which require proxying for proper lifecycle management.
  • Field Modifiers: The final modifier has been removed from several injected fields (eventBus, taskStore, pushSender, queueManager) within MainEventBusProcessor. This change is necessary because CDI's proxying mechanism calls the no-arg constructor first, and then injects dependencies, which is incompatible with final fields that must be initialized during construction.
Changelog
  • server-common/src/main/java/io/a2a/server/events/MainEventBusProcessor.java
    • Added a protected no-argument constructor for CDI proxying, annotated with @SuppressWarnings("NullAway").
    • Removed the final keyword from eventBus, taskStore, pushSender, and queueManager fields to allow CDI to inject them after the no-arg constructor is called.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 9, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a no-argument constructor to MainEventBusProcessor to ensure compatibility with Jakarta CDI's proxying mechanism for @ApplicationScoped beans. To accommodate this, the injected dependency fields have been made non-final. The change is well-justified and correctly implemented for the stated purpose.

@kabir kabir merged commit b103c8a into a2aproject:main Feb 9, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kabir