Skip to content

fix: InMemoryPushNotificationConfigStore uses wrong pagination token. #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kabir merged 1 commit into from
Dec 19, 2025
Merged

fix: InMemoryPushNotificationConfigStore uses wrong pagination token. #555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions server-common/src/main/java/io/a2a/server/tasks/InMemoryPushNotificationConfigStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,16 +70,16 @@ public ListTaskPushNotificationConfigResult getInfo(ListTaskPushNotificationConf
if (configs.size() <= params.pageSize()) {
return new ListTaskPushNotificationConfigResult(convertPushNotificationConfig(configs, params), null);
}
String newToken = configs.get(params.pageSize()).token();
String newToken = configs.get(params.pageSize()).id();
return new ListTaskPushNotificationConfigResult(convertPushNotificationConfig(configs.subList(0, params.pageSize()), params), newToken);
}

private int findFirstIndex(List<PushNotificationConfig> configs, String token) {
private int findFirstIndex(List<PushNotificationConfig> configs, String id) {
//find first index
Iterator<PushNotificationConfig> iter = configs.iterator();
int index = 0;
while (iter.hasNext()) {
if (token.equals(iter.next().token())) {
if (id.equals(iter.next().id())) {
return index;
}
index++;
Expand Down