feat: Set current protocol version to 1.0 #549
Conversation
Summary of ChangesHello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to standardize the A2A Protocol version across the entire codebase by defining it as a single, centralized constant. This change updates the protocol version to '1.0' and ensures that all components consistently reference this new constant, significantly improving maintainability and reducing the potential for version discrepancies throughout the project. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully refactors the codebase to use a constant for the protocol version, setting it to "1.0". This greatly improves maintainability by centralizing the version string. However, a critical issue exists in the form of an unresolved merge conflict within client/transport/jsonrpc/src/test/java/io/a2a/client/transport/jsonrpc/JsonMessages.java. This conflict must be resolved for the build to succeed. My review includes a specific suggestion to fix this.
client/transport/jsonrpc/src/test/java/io/a2a/client/transport/jsonrpc/JsonMessages.java
Outdated
Show resolved
Hide resolved
Update usage of protocol version to use a constant rather than hard coding
kabir
force-pushed
the
protocolversion-constant
branch
from
fae4c5a to
39cf737
Compare
Update usage of protocol version to use a constant rather than hard coding
2 participants
Update usage of protocol version to use a constant rather than hard coding