feat!: Replace public Builder constructors with static factory methods #540
Conversation
Summary of ChangesHello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the API for creating builder instances across various classes by replacing direct constructor calls with static factory methods. This change enhances the API's usability and adheres to modern Java best practices, making the code more idiomatic and maintainable. The update also includes minor API cleanups like renaming a method and removing a deprecated one, ensuring a more streamlined and consistent developer experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request consistently replaces public builder constructors with static factory methods across the codebase, which is a great improvement for API consistency and control over object creation. The changes are extensive and well-executed. I've found a couple of minor issues to address.
| .tags(Collections.singletonList("hello world")) | ||
| .examples(List.of("hi", "hello world")) | ||
| .build())) | ||
| .protocolVersion("0.3.0") |
There was a problem hiding this comment.
Maybe this should be updated to 1.0.0
There was a problem hiding this comment.
I'll do that in another PR coming soon
2 participants
Fixes #498 🦕