Skip to content

fix: Making the event queue overridable #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kabir merged 1 commit into from
Dec 12, 2025
Merged

fix: Making the event queue overridable #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions client/base/src/main/java/io/a2a/client/MessageEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,19 @@ public MessageEvent(Message message) {
public Message getMessage() {
return message;
}
}


@Override
public String toString() {
String messageAsString = "{"
+ "role=" + message.getRole()
+ ", parts=" + message.getParts()
+ ", messageId=" + message.getMessageId()
+ ", contextId=" + message.getContextId()
+ ", taskId=" + message.getTaskId()
+ ", metadata=" + message.getMetadata()
+ ", kind=" + message.getKind()
+ ", referenceTaskIds=" + message.getReferenceTaskIds()
+ ", extensions=" + message.getExtensions() + '}';
Comment on lines +27 to +36
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using StringBuilder for constructing the messageAsString will be more efficient and performant than repeated string concatenation with the + operator, especially if the Message object contains many fields or if this toString() method is called frequently. This is a common Java best practice for string building.

        String messageAsString = new StringBuilder("{")
                .append("role=").append(message.getRole())
                .append(", parts=").append(message.getParts())
                .append(", messageId=").append(message.getMessageId())
                .append(", contextId=").append(message.getContextId())
                .append(", taskId=").append(message.getTaskId())
                .append(", metadata=").append(message.getMetadata())
                .append(", kind=").append(message.getKind())
                .append(", referenceTaskIds=").append(message.getReferenceTaskIds())
                .append(", extensions=").append(message.getExtensions())
                .append('}')
                .toString();

return "MessageEvent{" + "message=" + messageAsString + '}';
}
}
12 changes: 6 additions & 6 deletions server-common/src/main/java/io/a2a/server/events/EventQueue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public int getQueueSize() {

public abstract void awaitQueuePollerStart() throws InterruptedException ;

abstract void signalQueuePollerStarted();
public abstract void signalQueuePollerStarted();

public void enqueueEvent(Event event) {
enqueueItem(new LocalEventQueueItem(event));
Expand All @@ -119,7 +119,7 @@ public void enqueueItem(EventQueueItem item) {
LOGGER.debug("Enqueued event {} {}", event instanceof Throwable ? event.toString() : event, this);
}

abstract EventQueue tap();
public abstract EventQueue tap();

/**
* Dequeues an EventQueueItem from the queue.
Expand Down Expand Up @@ -265,7 +265,7 @@ static class MainQueue extends EventQueue {
taskId, onCloseCallbacks.size(), taskStateProvider != null);
}

EventQueue tap() {
public EventQueue tap() {
ChildQueue child = new ChildQueue(this);
children.add(child);
return child;
Expand Down Expand Up @@ -310,7 +310,7 @@ public void awaitQueuePollerStart() throws InterruptedException {
}

@Override
void signalQueuePollerStarted() {
public void signalQueuePollerStarted() {
if (pollingStarted.get()) {
return;
}
Expand Down Expand Up @@ -415,7 +415,7 @@ private void internalEnqueueItem(EventQueueItem item) {
}

@Override
EventQueue tap() {
public EventQueue tap() {
throw new IllegalStateException("Can only tap the main queue");
}

Expand All @@ -425,7 +425,7 @@ public void awaitQueuePollerStart() throws InterruptedException {
}

@Override
void signalQueuePollerStarted() {
public void signalQueuePollerStarted() {
parent.signalQueuePollerStarted();
}

Expand Down