Skip to content

fix: NPE with test JSONRPCHandlerTest.testOnMessageNewMessageSuccessM… #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kabir merged 1 commit into from
Nov 5, 2025
Merged

fix: NPE with test JSONRPCHandlerTest.testOnMessageNewMessageSuccessM… #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion server-common/src/main/java/io/a2a/server/events/EnhancedRunnable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package io.a2a.server.events;

import java.util.ArrayList;
import java.util.List;
import java.util.concurrent.CopyOnWriteArrayList;

Expand Down
3 changes: 2 additions & 1 deletion transport/jsonrpc/src/test/java/io/a2a/transport/jsonrpc/handler/JSONRPCHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,8 @@ public void testOnMessageNewMessageSuccessMocks() {
SendMessageResponse response;
try (MockedConstruction<EventConsumer> mocked = Mockito.mockConstruction(
EventConsumer.class,
(mock, context) -> {Mockito.doReturn(ZeroPublisher.fromItems(wrapEvent(MINIMAL_TASK))).when(mock).consumeAll();})){
(mock, context) -> {Mockito.doReturn(ZeroPublisher.fromItems(wrapEvent(MINIMAL_TASK))).when(mock).consumeAll();
Mockito.doCallRealMethod().when(mock).createAgentRunnableDoneCallback();})){
Comment on lines +189 to +190
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability, it's good practice to format lambda bodies with multiple statements on separate lines with proper indentation. This makes the code easier to read and maintain.

                (mock, context) -> {
                    Mockito.doReturn(ZeroPublisher.fromItems(wrapEvent(MINIMAL_TASK))).when(mock).consumeAll();
                    Mockito.doCallRealMethod().when(mock).createAgentRunnableDoneCallback();
                })){

response = handler.onMessageSend(request, callContext);
}
assertNull(response.getError());
Expand Down