fix: NPE with test JSONRPCHandlerTest.testOnMessageNewMessageSuccessM… #446
Conversation
…ocks (a2aproject#444) Simple fix for JSONRPCHandlerTest.testOnMessageNewMessageSuccessMocks ensuring that the DoneCallback is not null when mocking. Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Summary of ChangesHello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a NullPointerException that was occurring in a specific test case, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request correctly addresses a NullPointerException in testOnMessageNewMessageSuccessMocks. I've added a suggestion to improve the formatting for readability.
Important: The same bug exists in other tests within JSONRPCHandlerTest.java which also use mockConstruction on EventConsumer but were not updated. To ensure test suite stability, please apply the same fix to testOnMessageNewMessageWithExistingTaskSuccessMocks, testOnMessageErrorMocks, testOnMessageStreamNewMessageSuccessMocks, and testOnMessageStreamNewMessageExistingTaskSuccessMocks.
The removal of the unused import in EnhancedRunnable.java is a good cleanup.
| (mock, context) -> {Mockito.doReturn(ZeroPublisher.fromItems(wrapEvent(MINIMAL_TASK))).when(mock).consumeAll(); | ||
| Mockito.doCallRealMethod().when(mock).createAgentRunnableDoneCallback();})){ |
There was a problem hiding this comment.
For better readability, it's good practice to format lambda bodies with multiple statements on separate lines with proper indentation. This makes the code easier to read and maintain.
(mock, context) -> {
Mockito.doReturn(ZeroPublisher.fromItems(wrapEvent(MINIMAL_TASK))).when(mock).consumeAll();
Mockito.doCallRealMethod().when(mock).createAgentRunnableDoneCallback();
})){2 participants
…ocks (#444)
Simple fix for JSONRPCHandlerTest.testOnMessageNewMessageSuccessMocks ensuring that the DoneCallback is not null when mocking.