fix: Make sure we use @Inject on @ConfigProperty #438
Conversation
Summary of ChangesHello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical compatibility requirement for Jakarta EE applications. By adding the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly adds the @Inject annotation to fields that use @ConfigProperty. This is a necessary change for compatibility with Jakarta EE, ensuring that configuration properties are properly injected. The changes in CloudAgentCardProducer.java and JpaDatabaseTaskStore.java are correct and address the issue. I have one minor suggestion regarding import styling to improve code consistency.
Jakarta needs this or it ignores the config
kabir
force-pushed
the
inject-config-properties-0.3.x
branch
from
26b3cc9 to
9360bc8
Compare
2 participants
Jakarta needs this or it ignores the config
Upstream: #437