Skip to content

fix: Make sure we use @Inject on @ConfigProperty #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kabir merged 1 commit into from
Nov 4, 2025
Merged

fix: Make sure we use @Inject on @ConfigProperty #437

kabir merged 1 commit into from
Nov 4, 2025

Conversation

@kabir
Copy link
Collaborator

@kabir kabir commented Nov 4, 2025

Jakarta needs this or it ignores the config

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 4, 2025

Summary of Changes

Hello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where configuration properties annotated with @ConfigProperty were being overlooked by Jakarta. By introducing the @Inject annotation alongside @ConfigProperty, the change guarantees that these essential configuration values are correctly injected into the application's components, thereby ensuring the application behaves as expected in a Jakarta environment.

Highlights

  • Jakarta Compatibility: Ensures that configuration properties annotated with @ConfigProperty are correctly recognized and injected within Jakarta environments.
  • Dependency Injection: Explicitly adds the @Inject annotation to fields that are already marked with @ConfigProperty to facilitate proper injection.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@kabir kabir mentioned this pull request Nov 4, 2025
Merged
gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 4, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the @Inject annotation to fields that use @ConfigProperty, which is necessary for dependency injection in Jakarta EE environments. The changes are correct and resolve the issue. I've added a couple of suggestions to improve encapsulation by making the injected fields private, which is a common best practice in CDI.

@kabir
fix: Make sure we use @Inject on @ConfigProperty
8e6a13e 
Jakarta needs this or it ignores the config
@kabir kabir force-pushed the inject-config-properties branch from 6160890 to 8e6a13e Compare November 4, 2025 13:36
@kabir kabir merged commit 5c5970d into a2aproject:main Nov 4, 2025
10 checks passed
kabir added a commit that referenced this pull request Nov 4, 2025
@kabir
fix: Make sure we use @Inject on @ConfigProperty (#438)
2e23b0b 
Jakarta needs this or it ignores the config

Upstream: #437
@jmesnil jmesnil added this to the 1.0.0 milestone Dec 11, 2025
kabir added a commit to kabir/a2a-java that referenced this pull request Dec 23, 2025
@kabir
fix: Make sure we use @Inject on @ConfigProperty (a2aproject#437)
6feb0d7 
Jakarta needs this or it ignores the config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsavoie ehsavoie ehsavoie approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kabir @ehsavoie @jmesnil