Skip to content

fix: fixing the handling of historyLength being set to 0 by default in gRPC #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kabir merged 1 commit into from
Nov 3, 2025
Merged

fix: fixing the handling of historyLength being set to 0 by default in gRPC #429

kabir merged 1 commit into from
Nov 3, 2025

Conversation

@ehsavoie
Copy link
Collaborator

@ehsavoie ehsavoie commented Nov 3, 2025 •
edited
Loading

  • Using int instead of Integer and setting the default value to 0.
  • If historyLength == 0 then we should return the full history
  • Removing the handling of null

Issue: #423

Fixes #423 🦕

@ehsavoie
fix: fixing the handling of historyLength being set to 0 by default in
094764a 
gRPC.

* Using int instead of Integer and setting the default value to 0.
* If historyLength == 0 then we should return the full history
* Removing the handling of null

Issue: a2aproject#423

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
@ehsavoie ehsavoie requested a review from kabir November 3, 2025 14:44
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 3, 2025

Summary of Changes

Hello @ehsavoie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the handling of the historyLength parameter across the application, primarily by converting it from a nullable Integer to a primitive int with a default value of 0. This change streamlines the logic for retrieving task history, ensuring that a historyLength of 0 correctly fetches the complete history and eliminates the need for explicit null checks, leading to more robust and predictable behavior.

Highlights

  • Type Change for historyLength: The historyLength parameter in TaskQueryParams and related methods has been changed from a nullable Integer to a primitive int, ensuring it always has a value and simplifying null checks.
  • Default Value Handling: The default value for historyLength is now explicitly set to 0. When historyLength is 0 or less, the system will return the full task history, addressing previous inconsistencies.
  • Removal of Null Checks: Code paths that previously checked for historyLength != null have been removed or updated, as the parameter is now a primitive int and cannot be null.
  • API and Test Adjustments: Client and server-side logic, including REST and gRPC transports, have been updated to reflect the int type for historyLength. Corresponding test cases have also been adjusted to pass 0 instead of null.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@ehsavoie ehsavoie changed the title fix: fixing the handling of historyLength being set to 0 by default in fix: fixing the handling of historyLength being set to 0 by default in gRPC Nov 3, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 3, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses the handling of historyLength by changing its type from Integer to int and defaulting it to 0. The logic is updated across the codebase to return the full history when historyLength is 0. The changes are consistent and well-implemented. I have one suggestion to simplify the logic in DefaultRequestHandler for improved efficiency and readability.

@kabir kabir merged commit f36db5e into a2aproject:main Nov 3, 2025
12 checks passed
kabir pushed a commit to kabir/a2a-java that referenced this pull request Nov 3, 2025
@ehsavoie @kabir
fix: fixing the handling of historyLength being set to 0 by default i…
52b3137 
…n gRPC (a2aproject#429)

* Using int instead of Integer and setting the default value to 0.
* If historyLength == 0 then we should return the full history
* Removing the handling of null

Issue: a2aproject#423

Fixes a2aproject#423 🦕

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
@ehsavoie ehsavoie deleted the issue_423 branch December 11, 2025 08:23
kabir pushed a commit to kabir/a2a-java that referenced this pull request Dec 23, 2025
@ehsavoie @kabir
fix: fixing the handling of historyLength being set to 0 by default i…
258b7ad 
…n gRPC (a2aproject#429)

* Using int instead of Integer and setting the default value to 0.
* If historyLength == 0 then we should return the full history
* Removing the handling of null

Issue: a2aproject#423

Fixes a2aproject#423 🦕

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kabir kabir Awaiting requested review from kabir

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: gRPC historyLength defaults to 0, causing different behavior than JSON-RPC/REST

2 participants

@ehsavoie @kabir