fix: Fix typo in Artifact.Builder#extensions #413
Conversation
Summary of ChangesHello @fjuma, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor code quality issue by fixing a typo in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a typo in the Artifact.Builder where a field was being assigned to itself twice. The change is good. I've added one suggestion to further improve the code by ensuring the extensions list is never null, which aligns with best practices and seems to be the convention in other parts of your codebase.
|
|
||
| public Builder extensions(List<String> extensions) { | ||
| this.extensions = this.extensions = (extensions == null) ? null : List.copyOf(extensions); | ||
| this.extensions = (extensions == null) ? null : List.copyOf(extensions); |
There was a problem hiding this comment.
While the typo fix is correct, consider initializing extensions to an empty list instead of null when the input is null. This avoids potential NullPointerExceptions for consumers of the Artifact object and aligns with the general best practice of returning empty collections instead of nulls. It also appears to be consistent with how other parts of the codebase handle collections, based on the tests for the Task class.
| this.extensions = (extensions == null) ? null : List.copyOf(extensions); | |
| this.extensions = (extensions == null) ? List.of() : List.copyOf(extensions); |
There was a problem hiding this comment.
Going to ignore this one since we use null elsewhere too.
3 participants
No description provided.