fix: Fixing build on Java 25. #329
Conversation
Summary of ChangesHello @ehsavoie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on resolving critical build and runtime issues that arise when the application is run on Java 25. The core problem, a classloading conflict related to Vert.x's JSON codec, is addressed by migrating Server-Sent Events (SSE) JSON serialization to use Jackson's Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a build failure on Java 25 by upgrading the Quarkus platform version and switching from the Vert.x JSON codec to Jackson's ObjectMapper for Server-Sent Events (SSE) serialization. The changes are logical and seem to correctly resolve the described classloading issue. I have added one comment regarding an opportunity to reduce code duplication in A2AServerRoutes.java to improve maintainability. Overall, this is a solid fix.
reference/jsonrpc/src/main/java/io/a2a/server/apps/quarkus/A2AServerRoutes.java
Outdated
Show resolved
Hide resolved
Removing the use of vertx json to serialize to String. Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Tests are failing on Java 25 because of a classloading issue if uwing vertx json codec instead of Jackson object mapper. Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
2 participants
Tests are failing on Java 25 because of a classloading issue if uwing vertx json codec instead of Jackson object mapper.