-
Notifications
You must be signed in to change notification settings - Fork 1
UN-2039 [FEAT] Add excel mode to LLMWhisperer v2 adapter settings #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UN-2039 [FEAT] Add excel mode to LLMWhisperer v2 adapter settings #198
Conversation
Added 'excel' as a supported processing mode in the JSON schema for LLMWhisperer v2 adapter. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Summary by CodeRabbit
WalkthroughAdds "excel" to the Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks (2 passed, 1 warning)❌ Failed Checks (1 warning)
✅ Passed Checks (2 passed)
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Cache: Disabled due to Reviews > Disable Cache setting Knowledge base: Disabled due to 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/unstract/sdk/adapters/x2text/llm_whisperer_v2/src/static/json_schema.json (2)
40-41: Confirm default remains “form”If Excel files are a common input, consider switching default contextually (e.g., by mime type) or documenting that users must select "excel".
102-107: Fix minor grammar in webhook description“which will should be called” → “that should be called”.
Apply this diff:
- "description": "The webhook's name which will should be called after the conversion is complete. The name should have been registered earlier using the webhooks management endpoint" + "description": "The webhook's name that should be called after the conversion is complete. The name should have been registered earlier using the webhooks management endpoint."
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to Reviews > Disable Cache setting
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting
📒 Files selected for processing (1)
src/unstract/sdk/adapters/x2text/llm_whisperer_v2/src/static/json_schema.json(1 hunks)
🔇 Additional comments (1)
src/unstract/sdk/adapters/x2text/llm_whisperer_v2/src/static/json_schema.json (1)
32-39: Excel mode added — manually verify handling in adapter, validations, mappings, and docsEnsure every code path that references native_text, low_cost, high_quality, form, or table also includes “excel” (adapter/client logic, server-side validations, switch/mapping statements) and update documentation/UI accordingly. For example, you can run:
grep -RlE 'native_text|low_cost|high_quality|form|table' . | xargs grep -L 'excel'
src/unstract/sdk/adapters/x2text/llm_whisperer_v2/src/static/json_schema.json
Show resolved
Hide resolved
Signed-off-by: jagadeeswaran-zipstack <jagadeeswaran@zipstack.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/unstract/sdk/__init__.py (1)
1-1: Optional: consider PEP 440 version format if used for packaging.If packaging tools read
__version__, PEP 440 prefers0.77.4(no leadingv). If your build metadata is elsewhere (e.g., pyproject), ignore.-__version__ = "v0.77.4" +__version__ = "0.77.4"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to Reviews > Disable Cache setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (1)
src/unstract/sdk/__init__.py(1 hunks)
Signed-off-by: jagadeeswaran-zipstack <jagadeeswaran@zipstack.com>
Signed-off-by: jagadeeswaran-zipstack <jagadeeswaran@zipstack.com>
Signed-off-by: jagadeeswaran-zipstack <jagadeeswaran@zipstack.com>
Summary
• Add 'excel' as a supported processing mode in the JSON schema for LLMWhisperer v2 adapter
Test plan
🤖 Generated with Claude Code