Version roll over for qdrant client - #185
Merged
Merged
Conversation
gaya3-vijayakumar
requested review from
athul-rs,
chandrasekharan-zipstack,
jaseemjaskp and
nehabagdia
March 26, 2024 08:59
chandrasekharan-zipstack
approved these changes
Mar 26, 2024
chandrasekharan-zipstack
left a comment
chandrasekharan-zipstack
left a comment
Contributor
There was a problem hiding this comment.
LGTM - the docker compose changes need to be present in unstract-cloud-platform repo as well
jaseemjaskp
approved these changes
Mar 26, 2024
athul-rs
approved these changes
Mar 26, 2024
hari-kuriakose
added a commit
that referenced
this pull request
Jul 31, 2026
View File History crashed the page with React #185 ("Maximum update depth exceeded"). antd tolerates an inline `rowSelection={{ selectedRowKeys, onChange }}` — a fresh object every render, which is what most call-sites write. The mirror effect depended on that object AND on the TanStack `table` (also rebuilt each render), so it re-ran on every commit; since it calls back into the parent's setState, that is an infinite loop. Hold both in refs and depend only on `selection`, which changes exactly when the user ticks a row — when antd would fire onChange. Verified against the reference, which opens the same modal cleanly, so this was a migration regression rather than pre-existing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Version roll over for qdrant client changes
Why
How
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.