Skip to content

UN-3099 [WIP] Fix trailing line from logs table left border - #1709

Closed
chandrasekharan-zipstack wants to merge 1 commit into
mainfrom
UN-3099-fix-trailing-line-in-logs-table
Closed

UN-3099 [WIP] Fix trailing line from logs table left border#1709
chandrasekharan-zipstack wants to merge 1 commit into
mainfrom
UN-3099-fix-trailing-line-in-logs-table

Conversation

@chandrasekharan-zipstack

@chandrasekharan-zipstack chandrasekharan-zipstack commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

What

Removes flex: 1 CSS property from .logs-table-container .ant-table-container that was causing the left border to extend outside the table container.

Why

The CSS property was causing the logs table border styling issue where the left border of the table extended beyond its container boundaries on the Execution Logs page
image

How

  • Removed the flex: 1 property from the .logs-table-container .ant-table-container CSS selector

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

No. This is a purely visual CSS fix that corrects a layout issue. The table functionality remains unchanged.

Related Issues or PRs

  • UN-3099

Dependencies Versions

  • None

Notes on Testing

Manual testing of the Execution Logs page to verify the table border displays correctly within its container.

Screenshots

image

Checklist

I have read and understood the Contribution Guidelines.

🧠 Generated with Claude Code

Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com

…s table

Removed the `flex: 1` property from `.logs-table-container .ant-table-container`
which was causing the left border of the table to extend outside its container.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

Removed the flex: 1 property from the .logs-table-container .ant-table-container CSS selector in the LogsTable component. This eliminates the container's ability to grow and fill available flex space within its parent layout.

Changes

Cohort / File(s) Change Summary
LogsTable styling adjustment
frontend/src/components/logging/logs-table/LogsTable.css
Removed flex: 1 property from .logs-table-container .ant-table-container selector

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description follows the template with complete sections including What, Why, How, impact assessment, related issues, testing notes, and screenshots demonstrating the fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The PR title accurately describes the main change: removing a CSS property (flex:1) that was causing a visual layout issue with the logs table's left border.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch UN-3099-fix-trailing-line-in-logs-table

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chandrasekharan-zipstack chandrasekharan-zipstack changed the title UN-3099 [FIX] Remove flex:1 causing left border to extend outside logs table UN-3099 [FIX] Fix trailing line from logs table left border Dec 17, 2025
@vishnuszipstack

Copy link
Copy Markdown
Contributor

@chandrasekharan-zipstack i have already fixed this in this PR #1707

@sonarqubecloud

Copy link
Copy Markdown

@chandrasekharan-zipstack

Copy link
Copy Markdown
Contributor Author

This can be considered only if the existing fix in #1707 does not resolve the issue. If it does fix it, we can close this PR

@chandrasekharan-zipstack chandrasekharan-zipstack changed the title UN-3099 [FIX] Fix trailing line from logs table left border UN-3099 [WIP] Fix trailing line from logs table left border Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants