workers/shared/workflow/destination_connector.py (1)

224-266: Refactor to reduce cognitive complexity and add recursion protection.

SonarCloud flags cognitive complexity of 28 (allowed: 15). The nested function with multiple conditionals is hard to follow. Additionally, deeply nested highlight data could cause stack overflow.

Consider refactoring to reduce nesting and add a depth limit:

 @staticmethod
-def _extract_confidence_from_highlight_data(data: Any) -> float | None:
+def _extract_confidence_from_highlight_data(
+    data: Any, max_depth: int = 50
+) -> float | None:
     """Extract confidence from 5th element of highlight data coordinate arrays.
-
-    Recursively searches through nested arrays/objects to find coordinate arrays
-    with 5 elements where the 5th element (index 4) is the confidence score.
-
-    Args:
-        data: Highlight data structure (can be nested arrays/dicts)
-
-    Returns:
-        Average confidence score if found, None otherwise
     """
     if not data:
         return None

     confidence_values = []

-    def extract_from_array(arr):
-        if isinstance(arr, list):
-            for item in arr:
-                if isinstance(item, list):
-                    # Check if this is a coordinate array with 5 elements
-                    if len(item) >= 5 and isinstance(item[4], (int, float)):
-                        confidence_values.append(float(item[4]))
-                    else:
-                        # Recursively check nested arrays
-                        extract_from_array(item)
-                elif isinstance(item, dict):
-                    # Recursively check objects
-                    for val in item.values():
-                        extract_from_array(val)
-        elif isinstance(arr, dict):
-            for val in arr.values():
-                extract_from_array(val)
+    def extract_recursive(arr, depth: int = 0):
+        if depth > max_depth:
+            return
+        if isinstance(arr, list):
+            # Check if this is a coordinate array with 5 elements
+            if len(arr) >= 5 and isinstance(arr[4], (int, float)):
+                confidence_values.append(float(arr[4]))
+                return
+            for item in arr:
+                extract_recursive(item, depth + 1)
+        elif isinstance(arr, dict):
+            for val in arr.values():
+                extract_recursive(val, depth + 1)

-    extract_from_array(data)
+    extract_recursive(data)

     if confidence_values:
         return sum(confidence_values) / len(confidence_values)
-
     return None

frontend/src/components/custom-tools/prompt-card/DisplayPromptResult.jsx (2)

138-138: Prefer replaceAll() for clarity.

While replace() with the global flag works, replaceAll() more explicitly conveys the intent to replace all occurrences.

Apply this diff:

-      const normalized = path.replace(/\[(\d+)\]/g, ".$1");
+      const normalized = path.replaceAll(/\[(\d+)\]/g, ".$1");

---

147-166: Consider adding comments to clarify the multi-tier fallback strategy.

The confidence computation uses a three-tier fallback (word-level → highlight-derived → explicit), but this strategy isn't immediately apparent from the code. Adding inline comments would improve maintainability.

Consider adding clarifying comments:

      let confidence;
+     // Tier 1: Try word-level confidence (most granular)
      if (shouldUseWordConfidence && wordConfidenceData) {
        const wordConfidence = getNestedValue(wordConfidenceData, key);
        if (wordConfidence && typeof wordConfidence === "object") {
          const values = Object.values(wordConfidence).filter(
            (v) => typeof v === "number"
          );
          if (values.length > 0) {
            const sum = values.reduce((acc, val) => acc + val, 0);
            confidence = sum / values.length;
          }
        }
      }

+     // Tier 2: Extract from highlight data coordinate arrays (5th element)
+     // Tier 3: Fall back to explicit confidence data
      if (confidence === undefined) {
        const extractedConfidence = extractConfidenceFromHighlightData(
          highlightData[key]
        );
        confidence = extractedConfidence ?? confidenceData?.[key];
      }

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to Reviews > Disable Cache setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting