Fix/Run script docker version update - #130
Merged
Merged
Conversation
hari-kuriakose
requested changes
Mar 18, 2024
hari-kuriakose
left a comment
Contributor
There was a problem hiding this comment.
@athul-rs Please change as per the comment.
Suggested improvement to add helper text if no argument added. Co-authored-by: Hari John Kuriakose <hari@zipstack.com> Signed-off-by: Athul <89829560+athul-rs@users.noreply.github.com>
nehabagdia
approved these changes
Mar 18, 2024
pk-zipstack
pushed a commit
that referenced
this pull request
Aug 20, 2025
* Fix/Run script docker version update * Update run-platform.sh Suggested improvement to add helper text if no argument added. Co-authored-by: Hari John Kuriakose <hari@zipstack.com> Signed-off-by: Athul <89829560+athul-rs@users.noreply.github.com> --------- Signed-off-by: Athul <89829560+athul-rs@users.noreply.github.com> Co-authored-by: Hari John Kuriakose <hari@zipstack.com> Co-authored-by: Neha <115609453+nehabagdia@users.noreply.github.com>
hari-kuriakose
added a commit
that referenced
this pull request
Jul 27, 2026
…udio Most severe defect so far: opening any Prompt Studio project showed "Couldn't load this page" and rendered nothing. Cause: PromptCardItems.jsx and NotesCard.jsx render `<Collapse.Panel>`, and SetOrg.jsx renders `<Card.Meta>`. Neither sub-component existed on the shims, so React received `undefined` as an element type and threw error #130. That does not degrade one component — it takes down the entire route. Collapse now supports both antd forms: the `items` data prop and the legacy `<Collapse><Collapse.Panel header=…>` children, including `showArrow={false}` which PromptCardItems relies on. Card.Meta renders avatar/title/description. Added a completeness guard (shim-completeness.test.jsx) instead of only fixing the two. It scans the app source for every `<Foo.Bar>` usage and asserts the shims actually expose it. The per-component tests could not have caught this: nothing in them rendered Collapse.Panel, so its absence was invisible until a real page tried. The guard covers 14 sub-components today and fails loudly for any future gap. It earned its place immediately — it caught that my first Collapse.Panel assignment had not landed (biome had reordered the export block my patch anchored to, so the edit silently no-opped). 176 tests across 16 files, build and lint at the 24-warning baseline. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
hari-kuriakose
added a commit
that referenced
this pull request
Jul 27, 2026
Found by the shim-completeness guard once the enterprise plugins were overlaid: ReviewHeader.jsx:910 renders <Dropdown.Button>Download File</...>, and Dropdown.Button was undefined. That is React error #130, which takes down the whole manual-review route rather than just the button — the same failure mode as the Collapse.Panel bug. Dropdown.Button is NOT Dropdown. In <Dropdown> the child IS the trigger, so naively aliasing the two would make "Download File" open a menu instead of downloading. antd's split button keeps the halves separate: children is a real action button wired to onClick, and only the chevron opens the menu. The three new tests pin exactly that separation, since it is the one thing an alias would silently get wrong. The chevron half carries aria-label="More actions" so both halves stay distinguishable by accessible name.
hari-kuriakose
added a commit
that referenced
this pull request
Jul 29, 2026
Modal, Tooltip, Dropdown, Popconfirm, Popover and Collapse now enumerate
the antd surface they accept — including the props that were previously
dropped or leaked:
- `open` / `visible` on the Popover. Radix reads a bare `open` as fully
controlled, so without a supplied handler Esc and outside-click could
not dismiss it.
- `trigger` / `arrow`, which are antd-only. They were reaching the DOM
and drawing unknown-attribute warnings; the interface now marks them
as consumed rather than forwarded.
tsc corrected my own model of the menu twice, which is the point of doing
this: antd marks separators with `type: "divider"` (my first interface
had no `type` at all), and its `onClick` payload carries `domEvent`
alongside the key. Both are used by existing call-sites.
`useModal` gains an explicit `[ModalApi, ReactElement | null]` tuple —
without it TypeScript widens the returned array to a union and the
destructured `api` loses its methods at every call-site.
Namespace objects (`Modal.confirm`, `Modal.useModal`, `Dropdown.Button`,
`Collapse.Panel`) move to Object.assign so the statics stay in the
inferred type and shim-completeness still resolves them by value. That
guard is what catches a missing sub-component before React error #130
takes down a whole route, which is how Prompt Studio crashed.
Verified: tsc --noEmit clean, vite build green, 250/250 tests pass,
including the Dropdown open/ref-forwarding regression tests.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
hari-kuriakose
added a commit
that referenced
this pull request
Jul 29, 2026
Completes src/components/ui/: all 32 primitives and all 9 shims are now TypeScript, with no `as any`, `@ts-ignore`, or bare `: any` anywhere in the layer. antd-structure is the widest surface — 19 components and 8 namespace statics, including the nested `List.Item.Meta`. All of them move to Object.assign so the statics stay in the inferred type and remain resolvable by value, which is how the shim-completeness guard finds a missing sub-component before React error #130 takes down a route. `Upload.Dragger` is why this file was worth typing carefully: it was once aliased to `Upload`, so the drop zone rendered as a plain button and drag-and-drop silently did nothing. Its props are now stated separately from Upload's. Corrections tsc forced, each a real mismatch rather than a conversion slip: - `Transfer.onChange` receives (nextTargetKeys, direction, movedKeys). My first interface declared only the first argument, and the call below passed three. - `Steps` renders an <ol>, not a <div>, so its ref type was wrong. - antd's `title` is a ReactNode, but the DOM attribute is a string — FloatButton was forwarding a node into it. - Radix Tabs Root accepts value/defaultValue/onValueChange only; the antd props were being spread onto it. Verified: tsc --noEmit clean, vite build green, 250/250 tests pass, biome lint at the committed 3-error/26-warning baseline. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
hari-kuriakose
added a commit
that referenced
this pull request
Aug 2, 2026
…nder Opening any Agentic Prompt Studio project died with "Couldn't load this page". The cause was React error #130 (args[]=undefined) — AccuracyOverviewPanel renders <Skeleton.Button> and <Skeleton.Input>, neither of which the shim defined, and an undefined element type takes down the whole route rather than just that component. Sweeping every `<Foo.Bar>` the plugin tree renders turned up a second one: <Menu.ItemGroup>, used by the verticals Playground — the same crash waiting on a different route. shim-completeness could not have caught either. It scans OSS `src/` for sub-component usage, and the plugins that use these live in a gitignored tree that is simply absent from an OSS checkout. Registering Skeleton there helps once plugins are present; the by-value assertions added alongside cover the case where they are not. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
hari-kuriakose
added a commit
that referenced
this pull request
Aug 2, 2026
Tab height. antd pads line-style tabs `12px 0` for a 46px nav. I had set `py-0` globally to fix ONE call-site — the doc-manager toolbar, which centres its tabs against a file name and 32px buttons, where padding pushes the label above the row's centre line. That made every other nav half height: Agentic Prompt Studio's project tabs measured 24px against the reference's 46px. Pad by default and let that toolbar opt out in its own CSS, rather than making every standalone nav wrong to suit it. Also adds tests/e2e/ui/agentic-prompt-studio.spec.js, covering the path that broke: listing -> open project -> authoring surface renders, all eight tabs present, and the two authoring tabs render their controls. The crash asserted against is the Skeleton.Button #130 — invisible to vitest unless something renders that exact sub-component, and invisible to shim-completeness because it scans OSS src/ while these plugins are gitignored. Walked Schema, Extraction Prompt and Settings against us-central: buttons and copy match the reference exactly. The tab height was the only mismatch. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
How
Default version : latest
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.