[Fix] Sanitize file titles from H1 headings #5983
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest commit refactors the ast extractors into a switch statement, matching the node parser structure and making it much more readable in my opinion. I also believe I was able to fix #5966. All that was missing was the |
|
Conan, what is best in life? 🤔
I am McLovin' your work Bennie, rock on! ✌️ LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds sanitization to H1 headings when they are extracted for file display.
Closes #5980
Closes #5966
Changes
Instead of assigning
firstHeadingto the heading node content, the plain text is extracted usingextractTextNodes. This removes any markup that is in the heading.The
extractTextNodesfunction was refactored to include theZettelkastenLinktitle, which matchesLinkandImagenodes.Additional information
Title:
Current:
PR:
Tested on: macOS 26